Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization of group description and picture #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vadimonus
Copy link

Synchronization of group description and picture

@paulholden
Copy link
Owner

Thanks @vadimonus! Don't we need to actually move the picture too? e.g. the picture used in the "meta group" should exist independently from the original?

@vadimonus
Copy link
Author

In our case we use groups with meta synchronizaion to make groups be the same in many courses. If we do not move picture and description, groups will not look like the same, and teachers or administrators will need some more time to clone description and pictures to many courses.
We can add plugin config setting to determine, if picture and description should be synced. What do you think about such solution?

@paulholden
Copy link
Owner

paulholden commented Oct 29, 2020

Hi @vadimonus - I was just trying out your PR. My previous point stands, if a group in the parent course has a "picture" set, or an image within the "description" field, then those files need copying to the child course and linked to the new meta-group

Testing now, I can see this isn't the case. The "picture" is missing, and the image within the "description" field is missing in the meta-group - are you able to address that (I've added screenshots to demonstrate)?

Screenshot from 2020-10-29 14-10-04

Screenshot from 2020-10-29 14-10-19

Also, could you revert version change?

@vadimonus
Copy link
Author

@paulholden That's just part part of commits, that was made more than two years ago. I've just rebased them. I will test it on latest moodle version and fix it

@vadimonus
Copy link
Author

@paulholden Вetter late than never. I've rewritten code to fix problems. Images in description and icon now should sync as expected.

@vadimonus
Copy link
Author

@paulholden Would you have some time to check this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants