Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jump-links): fix missing comma throwing off chrome css parser #2851

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Sep 23, 2024

Centered and Vertical were being incorrectly rendered due to a parsing issue cause by the missing comma in the CSS vars.

What I did

  1. Reformatted CSS block, added previously missing comma which was throwing off Chrome 129 CSS parser.

Thanks @rmscampos for the report

Testing Instructions

  1. View the Deploy Preview

Notes to Reviewers

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 20c01eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(jump-links): fix missing comma throwing off chrome css parser"
}

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 8ef7a11
😎 Deploy Preview https://deploy-preview-2851--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Sep 23, 2024
@zeroedin zeroedin marked this pull request as ready for review September 23, 2024 18:20
@zeroedin zeroedin self-assigned this Sep 23, 2024
.changeset/fresh-donuts-count.md Show resolved Hide resolved
.changeset/fresh-donuts-count.md Outdated Show resolved Hide resolved
@bennypowers bennypowers enabled auto-merge (squash) September 25, 2024 11:15
@bennypowers bennypowers merged commit 155911d into main Sep 25, 2024
21 of 25 checks passed
@bennypowers bennypowers deleted the fix/jump-links/missing-css-comma branch September 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants