-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Place coding examples with legacy-like structure #19
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # README.md
add example
add example
Signed-off-by: Doomsk <[email protected]>
One question, if you consider this to be a "legacy-like" structure, is there some specific new structure that should be used instead? If yes, it would be good to have the examples in that format as well. |
add legacy operations Signed-off-by: Doomsk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an intermediary review. Minor comments there otherwise LGTM.
docs/getting_started_example.md
Outdated
expr = RX(1.57 * a)(0) * RY(0.707 * a ** 2)(0) | ||
print(f"expression: {str(expr)}") | ||
|
||
add_qpu_directives({"digital": True}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
n_qubits = 2 | ||
|
||
# I will just copy the value from C6_DICT[60] since there's not such a dict in qadence2 | ||
C6 = 865723.02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more comment about what this constant is and units.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject.toml
Outdated
"qadence2-ir==0.1.1", | ||
"qadence2-expressions==0.1.1", | ||
"pyqtorch==1.3.2", | ||
"qadence2-ir~=0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's better to remove pinning the dependencies ?
Signed-off-by: Doomsk <[email protected]>
Signed-off-by: Doomsk <[email protected]>
# Conflicts: # examples/pyq_compiler.py # pyproject.toml
Add example given by João to compare with current Qadence 1 code:
and Qadence 2: