Define node instances in format "${chain}-${name}" #670
+123
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis.drozhzhin <[email protected]>
|
User @muctep-dehuc, please sign the CLA here. |
Signed-off-by: denis.drozhzhin <[email protected]>
Signed-off-by: denis.drozhzhin <[email protected]>
pepoviola
reviewed
Dec 24, 2022
| @@ -94,6 +111,7 @@ export async function genNodeDef( | |||
| runAsUser: 1000, | |||
| runAsGroup: 1000, | |||
| }, | |||
| imagePullSecrets: [{ name: "gitlab" }], | |||
There was a problem hiding this comment.
This should be configurable if needed by the users.
pepoviola
reviewed
Dec 24, 2022
| @@ -111,6 +129,8 @@ function make_transfer_containter(): any { | |||
| "ash", | |||
| "-c", | |||
| [ | |||
| "sleep 60", | |||
There was a problem hiding this comment.
There is any reason to sleep before download curl?
|
Hi @MucTepDayH16, I like the idea! thanks for the I will also check the test in our ci. thanks for contributing!! |
Signed-off-by: denis.drozhzhin <[email protected]>
|
Sorry, just left some artifacts from our fork |
|
@pepoviola as for the offtop, will there be an opportunity to fetch images from non-public repo using |
|
@MucTepDayH16 any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to name nodes in different chains with non-unique names.
Naming like "polkadot-alice", "statemint-alice", "equilibrium-alice" is more obvious than "alice", "alice1", "alice2", ...