Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that spawning network in k8s should be in default namespace #1439

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Clarify that spawning network in k8s should be in default namespace #1439

wants to merge 14 commits into from

Conversation

Neyromancer
Copy link
Contributor

@Neyromancer Neyromancer commented Oct 20, 2023 •
edited
Loading

Description

While trying to spawn a network in kubernetes an error occures when namesapce is set to a value different from default:

Error:  	 Error: Command failed with exit code 1: kubectl --kubeconfig /Users/wirednkod/.kube/config apply -f -
Error from server (NotFound): error when creating "STDIN": namespaces "zombie-b3b08c66fc8e8e48d2876049d4477f7e" not found
Error from server (NotFound): error when creating "STDIN": namespaces "zombie-b3b08c66fc8e8e48d2876049d4477f7e" not found
Error from server (NotFound): error when creating "STDIN": namespaces "zombie-b3b08c66fc8e8e48d2876049d4477f7e" not found
Error from server (NotFound): error when creating "STDIN": namespaces "zombie-b3b08c66fc8e8e48d2876049d4477f7e" not found

Related Issue #1412 Error when trying to spawn network in kubernetes

Tasks:

  • Make clear in the docs that you need to be set in the default namespace to start working with zombienet.
  • Print a warning at start that different then default namspace is used
  • Code review
  • Test

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 20, 2023

User @Neyromancer, please sign the CLA here.

@Neyromancer Neyromancer changed the title Updated required repo Clarify that spawning network in k8s should be in default namespace Oct 20, 2023
@wirednkod wirednkod self-requested a review October 24, 2023 06:50
@Neyromancer Neyromancer mentioned this pull request Nov 9, 2023
Closed
@Neyromancer Neyromancer force-pushed the Update_docs_on_spawning_network_in_k8s branch from e7f2874 to 9348474 Compare November 9, 2023 21:26
wirednkod
wirednkod reviewed Nov 10, 2023
View reviewed changes
javascript/words.txt Outdated Show resolved Hide resolved
@wirednkod
Copy link
Contributor

@Neyromancer Thank you for the contributions. Just a reminder that docs will automatically update so there is no need to manual edit them

@wirednkod wirednkod self-requested a review November 10, 2023 11:21
pepoviola
pepoviola reviewed Nov 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Neyromancer
Copy link
Contributor Author

i am also going to add logs with current namespace

@Neyromancer Neyromancer force-pushed the Update_docs_on_spawning_network_in_k8s branch from f1bb12f to 4db436b Compare November 10, 2023 21:53
@wirednkod
Copy link
Contributor

@Neyromancer is this ready for review?
@pepoviola if this looks fine - I think we can merge it. What do you think?

@pepoviola
Copy link
Collaborator

ping @Neyromancer are you still working on this?
Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola left review comments

@wirednkod wirednkod Awaiting requested review from wirednkod

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neyromancer @wirednkod @pepoviola