-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add params for delay in k8s #1147
Conversation
Hey @wirednkod, this will not works since we need to deploy a Ping me tested if you want. Thanks!! |
…t into nik-add-delay-params
…t into nik-add-delay-params
javascript/packages/orchestrator/src/providers/k8s/resources/chaosResource.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/k8s/resources/chaosResource.ts
Outdated
Show resolved
Hide resolved
javascript/packages/orchestrator/src/providers/k8s/kubeClient.ts
Outdated
Show resolved
Hide resolved
…t into nik-add-delay-params
…t into nik-add-delay-params
@wirednkod, I added a new test for our Thanks! |
Hi @wirednkod, I will refactor this since applying the delay when we create the pods cause performance issues with the spawn of the network. I will change the logic to spawn the network and apply all the manifest at once before returning the network instance. |
Thank you @pepoviola |
javascript/packages/orchestrator/src/providers/k8s/kubeClient.ts
Outdated
Show resolved
Hide resolved
Delay test is now green @wirednkod, I think we can merge this on as is. I will open a new issue to support add/remove |
@wirednkod merging now, and I created this followup issue #1302 We should also add the docs for this settings in the spawn phase. |
Fixes #927