Skip to content

Commit

Permalink
ci-fixes, on dumpLogs map before allSettled
Browse files Browse the repository at this point in the history
  • Loading branch information
pepoviola committed Oct 1, 2024
1 parent b0ec05d commit 55b482c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
9 changes: 5 additions & 4 deletions javascript/packages/orchestrator/src/network.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,11 @@ export class Network {
[],
);

const dumpsPromises = this.relay.concat(paraNodes).map((node) => {
this.client.dumpLogs(this.tmpDir, node.name);
});
await Promise.allSettled(dumpsPromises);
const dumpsNodes = this.relay.concat(paraNodes);
await Promise.allSettled(dumpsNodes.map((node) => {

Check failure on line 172 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Insert `⏎······`

Check failure on line 172 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (19.x)

Insert `⏎······`

Check failure on line 172 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (20.x)

Insert `⏎······`
this.client.dumpLogs(this.tmpDir, node.name);
})

Check failure on line 174 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Insert `,`

Check failure on line 174 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (19.x)

Insert `,`

Check failure on line 174 in javascript/packages/orchestrator/src/network.ts

View workflow job for this annotation

GitHub Actions / build (20.x)

Insert `,`
);

if (showLogPath)
new CreateLogTable({ colWidths: [20, 100] }).pushToPrint([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,7 @@ export class KubeClient extends Client {
// We should read it from host filesystem to ensure we are reading all the logs.

// First get the logs files to check if we need to read from disk or not
debugLogs("getting logFiles for:", podName);
const logFiles = await this.gzippedLogFiles(podName);
debugLogs("logFiles", logFiles);
let logs = "";
Expand Down

0 comments on commit 55b482c

Please sign in to comment.