Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename squatted crates #7504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename squatted crates #7504

wants to merge 1 commit into from

Conversation

Morganamilo
Copy link
Contributor

This commit adds the staging- prefix to squatted crates so we can go forward and publish them to crates.io.

Using the staging- prefix is a temp fix until we decide on replacement names. https://forum.parity.io/t/renaming-squated-crates-in-substrate-polkadot-cumulus/1964/6

@Morganamilo
Copy link
Contributor Author

These changes mean cumulus also needs some adjusting. I've made a PR here paritytech/cumulus#2880 that makes the needed changes. These PR's should land together to keep everything working. What's the best way to manage synchronising this?

@ggwpez
Copy link
Member

ggwpez commented Jul 17, 2023

DQ but do we actually want to rename the crates, or rather just publish them under a different name?
Latter would mean that we write a script that renames them just prior to publishing but leaves the original names untouched.

@Morganamilo
Copy link
Contributor Author

I think having the crates under two names will be very confusing.

ggwpez
ggwpez approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the crates under two names will be very confusing.

Yea personally I am fine with both. But please again post in the forum and link this MR - in case there are further comments.

ggwpez

This comment was marked as duplicate.

Sign in to view

@Morganamilo
Copy link
Contributor Author

The naming suggestion comes from the forums. Surely there's no need to pass it back there?

@Morganamilo Morganamilo added D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. F3-breaks_API This PR changes public API; next release should be major. T2-API This PR/Issue is related to APIs. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 19, 2023
@Morganamilo Morganamilo marked this pull request as ready for review July 19, 2023 12:25
@Morganamilo Morganamilo added the A0-please_review Pull request needs code review. label Jul 19, 2023
@Morganamilo
Copy link
Contributor Author

Hi, is there any way to move this forward?

@ggwpez
Copy link
Member

ggwpez commented Jul 25, 2023

Hi, is there any way to move this forward?

The CI needs to be green. Currently it fails with https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3199201

@Morganamilo
Rename squatted crates
6441cf0 
This commit adds the staging- prefix to squatted crates so we can go
forward and publish them to crates.io.

Using the staging- prefix is a temp fix until we decide on replacement names.
https://forum.parity.io/t/renaming-squated-crates-in-substrate-polkadot-cumulus/1964/6
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3342388

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@coderobe coderobe coderobe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. F3-breaks_API This PR changes public API; next release should be major. T2-API This PR/Issue is related to APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Morganamilo @ggwpez @paritytech-cicd-pr @coderobe