Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #8615: enrich metadata with type information #3336

Merged
merged 173 commits into from
Sep 15, 2021

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Jun 21, 2021

@ascjones
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 15, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Availability and Validity' does not match any projects in polkadot's Process.json
  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

@ordian
Copy link
Member

ordian commented Sep 15, 2021

bot merge

@ghost
Copy link

ghost commented Sep 15, 2021

Waiting for commit status.

@ordian
Copy link
Member

ordian commented Sep 15, 2021

(fmt and spellcheck are ignored by bot)

@ordian
Copy link
Member

ordian commented Sep 15, 2021

the check-transaction-versions if failing though:

2021-09-15 12:50:29        API/INIT: Error: FATAL: Unable to initialize the API: Cannot convert metadata from version 14 to 13
    at EventEmitter.value (/usr/local/lib/node_modules/@polkadot/metadata-cmp/node_modules/@polkadot/api/base/Init.cjs:82:25)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at runNextTicks (node:internal/process/task_queues:63:3)
    at processImmediate (node:internal/timers:437:9)

@jacogr
Copy link
Contributor

jacogr commented Sep 15, 2021

Indeed. 2 issues -

  1. The API PR has not been merged/released as of yet (so the comparator doesn't understand v14), see Parsing for metadata v14 polkadot-js/api#3759
  2. The metadata compare has not been revamped for v14 (there is some work left since the type compares now need to be done differently), see Adapt metadata compare for v14 polkadot-js/tools#267

1 above will happen first, 2 above needs to wait until after polkadot-js/apps#5927 (no dependency between 2 and that, however I can only focus/do one at a time)

@bkchr
Copy link
Member

bkchr commented Sep 15, 2021

@jacogr So, I assume we should disable the check until it works again?

@jacogr
Copy link
Contributor

jacogr commented Sep 15, 2021

Hopefully sorted by Monday, aka need to get all released by then. But yes, would disable it at present.

@ascjones
Copy link
Contributor Author

It seems the removed check is lingering.

@ordian
Copy link
Member

ordian commented Sep 15, 2021

@TriplEight ^^^

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Sep 15, 2021

Trying merge.

@rphmeier rphmeier merged commit 7bf12d6 into master Sep 15, 2021
@rphmeier rphmeier deleted the aj-metadata-vnext branch September 15, 2021 20:38
@ghost
Copy link

ghost commented Sep 16, 2021

Merge aborted: Head SHA changed from c86a008 to ff5e6b7

ordian added a commit that referenced this pull request Sep 16, 2021
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
ordian added a commit that referenced this pull request Sep 17, 2021
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
@chevdor chevdor added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants