fix prospective-parachains best backable chain reversion bug #6417
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindima
added
I2-bug
bkchr
approved these changes
Nov 8, 2024
eskimor
approved these changes
Nov 8, 2024
lexnv
approved these changes
Nov 8, 2024
|
/cmd prdoc --audience node_dev |
bkchr
added
the
A4-needs-backport
bkchr
reviewed
Nov 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Kudos to @EclesioMeloJunior for noticing it Also added a regression test for it. The existing unit test was exercising only the case where the full chain is reverted --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Kudos to @EclesioMeloJunior for noticing it Also added a regression test for it. The existing unit test was exercising only the case where the full chain is reverted --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 05ad547)
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Kudos to @EclesioMeloJunior for noticing it Also added a regression test for it. The existing unit test was exercising only the case where the full chain is reverted --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 05ad547)
EgorPopelyaev
pushed a commit
that referenced
this pull request
Nov 12, 2024
Backport #6417 into `stable2409` from alindima. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alin Dima <[email protected]>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Nov 12, 2024
Backport #6417 into `stable2407` from alindima. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alin Dima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @EclesioMeloJunior for noticing it
Also added a regression test for it. The existing unit test was exercising only the case where the full chain is reverted