Remove stale extension version from `UncheckedExtrinsic` v4 structure #6404

georgepisaltu · 2024-11-07T13:12:50Z

Follow up to #3685

The main PR introduced bare support for the new extension version byte. However, the extension version byte is not used for the old signed extrinsic type in version 4. This PR removes the byte from that structure, previously unused and defaulted to 0.

In this same PR, new weights will be generated for the modules affected by the main PR.

Signed-off-by: georgepisaltu <[email protected]>

georgepisaltu · 2024-11-07T13:13:06Z

bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T13:13:12Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719043 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 48-ebb9c2fd-8f26-45c1-9d8c-c1f961652d92 to cancel this command or bot cancel to cancel all commands in this pull request.

georgepisaltu · 2024-11-07T13:13:17Z

bot bench-all cumulus -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T13:13:24Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719044 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=asset-hub-rococo --target_dir=cumulus. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 49-aca594ff-91ac-4497-b5f9-6ed2d8013c7e to cancel this command or bot cancel to cancel all commands in this pull request.

georgepisaltu · 2024-11-07T13:13:32Z

bot bench-all polkadot -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T13:13:37Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719045 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=rococo --target_dir=polkadot. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 50-0a7461ac-771d-414f-b784-ab48badd473d to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-07T13:14:44Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719043 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719043/artifacts/download.

georgepisaltu · 2024-11-07T13:21:56Z

bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T13:22:02Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719176 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 51-10ec249c-ad9a-4d71-9f28-51d7d7e2e731 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-07T13:23:01Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719176 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719176/artifacts/download.

georgepisaltu · 2024-11-07T13:56:45Z

bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T13:56:51Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719627 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 52-7083c6b1-1d15-4867-8354-075c45410048 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-11-07T13:58:55Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate --features=riscv has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719627 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719627/artifacts/download.

georgepisaltu · 2024-11-07T14:00:43Z

bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext

command-bot · 2024-11-07T14:00:49Z

@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719693 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 53-c537172e-25e5-480f-8b7e-cf658136abe9 to cancel this command or bot cancel to cancel all commands in this pull request.

…ococo --target_dir=cumulus

command-bot · 2024-11-07T15:43:41Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=asset-hub-rococo --target_dir=cumulus has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719044 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719044/artifacts/download.

…6380) This PR ensures that external addresses with different PeerIDs are not propagated to the higher layer of the network code. While at it, this ensures that libp2p only adds the `/p2p/peerid` part to the discovered address if it does not contain it already. This is a followup from: - #6298 cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Dmitry Markin <[email protected]>

Fixes #5530 This PR introduces the removal of backing jobs that have been back pressured for longer than `allowedAncestryLen`, as these candidates are no longer viable. It is reasonable to expect a result for a backing job execution within `allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay block number and synchronize the validation host by sending activated leaves. --------- Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Branislav Kontur <[email protected]>

command-bot · 2024-11-07T19:36:18Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=substrate has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719693 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719693/artifacts/download.

gui1117 · 2024-11-08T01:21:55Z

polkadot/node/core/backing/src/lib.rs

@@ -632,6 +632,7 @@ async fn request_candidate_validation(
 ) -> Result<ValidationResult, Error> {
 	let (tx, rx) = oneshot::channel();
 	let is_system = candidate_receipt.descriptor.para_id().is_system();
+	let relay_parent = candidate_receipt.descriptor.relay_parent();


why all these changes in backing?

The bot rebased or formatted the code. You can see my initial commit here, the rest of the changes are pushed by the bot.

…rget_dir=polkadot

command-bot · 2024-11-08T02:53:31Z

@georgepisaltu Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=rococo --target_dir=polkadot has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719045 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719045/artifacts/download.

…-fixes

Signed-off-by: georgepisaltu <[email protected]>

georgepisaltu · 2024-11-08T15:18:28Z

Closing in favor of #6418

Remove stale extenstion version from v4 struct

d0f7978

Signed-off-by: georgepisaltu <[email protected]>

georgepisaltu added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Nov 7, 2024

georgepisaltu self-assigned this Nov 7, 2024

georgepisaltu requested a review from a team as a code owner November 7, 2024 13:12

georgepisaltu mentioned this pull request Nov 7, 2024

Transaction weight bloated by 2.5x in the latest release #6403

Open

".git/.scripts/commands/bench-all/bench-all.sh" --runtime=asset-hub-r…

9d68ef1

…ococo --target_dir=cumulus

lexnv and others added 3 commits November 7, 2024 19:36

".git/.scripts/commands/bench-all/bench-all.sh" --target_dir=substrate

f2c3d97

paritytech-ci requested review from acatangiu and cheme as code owners November 7, 2024 19:36

gui1117 reviewed Nov 8, 2024

View reviewed changes

".git/.scripts/commands/bench-all/bench-all.sh" --runtime=rococo --ta…

b6b54e7

…rget_dir=polkadot

Merge remote-tracking branch 'origin/master' into george-tx-ext-minor…

f4b6827

…-fixes

georgepisaltu changed the title ~~Remove stale extenstion version from UncheckedExtrinsic v4 structure~~ Remove stale extension version from UncheckedExtrinsic v4 structure Nov 8, 2024

Add prdoc

5405cfe

Signed-off-by: georgepisaltu <[email protected]>

georgepisaltu closed this Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove stale extension version from `UncheckedExtrinsic` v4 structure #6404

Remove stale extension version from `UncheckedExtrinsic` v4 structure #6404

georgepisaltu commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024

command-bot bot commented Nov 7, 2024

gui1117 Nov 8, 2024

georgepisaltu Nov 8, 2024

command-bot bot commented Nov 8, 2024

georgepisaltu commented Nov 8, 2024

Remove stale extension version from UncheckedExtrinsic v4 structure #6404

Remove stale extension version from UncheckedExtrinsic v4 structure #6404

Conversation

georgepisaltu commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

command-bot bot commented Nov 7, 2024

georgepisaltu commented Nov 7, 2024

command-bot bot commented Nov 7, 2024 • edited Loading

command-bot bot commented Nov 7, 2024

command-bot bot commented Nov 7, 2024

gui1117 Nov 8, 2024

Choose a reason for hiding this comment

georgepisaltu Nov 8, 2024

Choose a reason for hiding this comment

command-bot bot commented Nov 8, 2024

georgepisaltu commented Nov 8, 2024

Remove stale extension version from `UncheckedExtrinsic` v4 structure #6404

Remove stale extension version from `UncheckedExtrinsic` v4 structure #6404

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024 •

edited

Loading

command-bot bot commented Nov 7, 2024 •

edited

Loading