runtimes: presets are provided as config patches #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
changed the title
michalkucharczyk
added
R0-silent
gui1117
approved these changes
Nov 5, 2024
gui1117
reviewed
Nov 6, 2024
iulianbarbu
reviewed
Nov 6, 2024
iulianbarbu
approved these changes
Nov 6, 2024
bkchr
approved these changes
Nov 8, 2024
michalkucharczyk
commented
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces usage of
build_struct_json_patchmacro in all runtimes (also guides) within the code base.It also fixes macro to support field init shorthand, and Struct Update syntax which were missing in original implementation.
Follow up of #5700 and #5813