Expose more syncing types to enable custom syncing strategy #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit exposes additional syncing types to facilitate the development of a custom syncing strategy based on the existing Polkadot syncing strategy. Specifically, my goal is to isolate the state sync and chain sync components, allowing the state to be downloaded from the P2P network without running a full Substrate node. And I need to intercept the state responses during the state sync process. The newly exposed types are necessary to implement this custom syncing strategy.
The link is broken and this comment is not accurate as the state sync could be part of fast sync as well, thus removing the specific WarpSync for simplicity.
|
@bkchr @dmitry-markin Could you please take a look at this tiny PR? It should be real quick. All types exposed here are needed in my custom syncing strategy. |
dmitry-markin
approved these changes
Nov 1, 2024
…nto expose-more-syncing-types-for-custom-syncing-strategy
|
@lexnv @dmitry-markin Anything missing to merge this? |
Merged
via the queue into
paritytech:master
with commit Nov 7, 2024
0e09ad4
245 of 249 checks passed
liuchengxu
deleted the
expose-more-syncing-types-for-custom-syncing-strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes additional syncing types to facilitate the development of a custom syncing strategy based on the existing Polkadot syncing strategy. Specifically, my goal is to isolate the state sync and chain sync components, allowing the state to be downloaded from the P2P network without running a full regular Substrate node. I also need to intercept the state responses during the state sync process.
The newly exposed types are necessary to implement this custom syncing strategy.