Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate binaries feature was refactored #43

Merged
merged 2 commits into from
Aug 28, 2023
Merged

separate binaries feature was refactored #43

merged 2 commits into from
Aug 28, 2023

Conversation

kogeler
Copy link
Contributor

@kogeler kogeler commented Aug 28, 2023

The current implementation of separate binaries has some disadvantages:

  • previously added separate binary options have hidden logic. For example, they affect behavior of existing variables. node_binary variable has to contain a root HTTP path or link to a file depending of other variables
  • we can't use different roots for the binary HTTP links
  • we can't use arbitrary file names in binary HTTP links
  • we can't deploy more than one node on one instances because worker binary files will overwrite each other

These changes make the separate binary configurate flatter (without lists) and clear. I don't think that we will have tens of separate worker binaries in the future.

@kogeler kogeler requested a review from BulatSaif August 28, 2023 08:51
Copy link
Contributor

@PierreBesson PierreBesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how these changes would behave for a variety of nodes. Could you check its compatibility with at least polkadot/cumulus.

roles/node/templates/node.service.j2 Outdated Show resolved Hide resolved
Signed-off-by: kogeler <[email protected]>
@kogeler kogeler merged commit a43ac1c into main Aug 28, 2023
2 checks passed
@kogeler kogeler deleted the separate-binaries branch August 28, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants