Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding COEP/COOP headers #6789

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Revert adding COEP/COOP headers #6789

merged 1 commit into from
Aug 29, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Aug 28, 2021

Revert #6404

There are many more people using third-party resources than SharedArrayBuffer... #6561

Related: parcel-bundler/website#884

@height
Copy link

height bot commented Aug 28, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.93s -18.00ms
Cached 314.00ms +7.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 554.00ms -60.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 555.00ms -59.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 554.00ms -60.00ms 🚀
dist/legacy/index.8833cebd.js 1.54kb +0.00b 819.00ms -75.00ms 🚀
dist/legacy/index.01f0ce7e.js 1.15kb +0.00b 819.00ms -75.00ms 🚀
dist/modern/index.65a4b415.js 1.08kb +0.00b 818.00ms -76.00ms 🚀
dist/legacy/index.html 775.00b +0.00b 944.00ms -60.00ms 🚀
dist/modern/index.html 715.00b +0.00b 944.00ms -59.00ms 🚀
dist/legacy/index.5ba75694.css 77.00b +0.00b 1.06s -60.00ms 🚀
dist/modern/index.14235cd8.css 77.00b +0.00b 1.06s -60.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 555.00ms -31.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 555.00ms -32.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 555.00ms -32.00ms 🚀
dist/legacy/index.html 775.00b +0.00b 951.00ms -53.00ms 🚀
dist/modern/index.html 715.00b +0.00b 950.00ms -54.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 10.04s +29.00ms
Cached 454.00ms +20.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.70s -879.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.12m -74.00ms
Cached 1.64s -138.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.5e882c87.js 1.77mb -4.00b 🚀 19.25s -251.00ms
dist/EmojiPickerComponent.adbf03cc.js 146.66kb +0.00b 32.04s +10.78s ⚠️
dist/esm.ee2a08d5.js 33.13kb +0.00b 32.04s +10.78s ⚠️
dist/DatePicker.7cd2149c.js 22.96kb +0.00b 32.04s +10.78s ⚠️
dist/js.0f0bb621.js 17.24kb +0.00b 51.04s +12.37s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.56kb +0.00b 51.04s +12.38s ⚠️
dist/feedback.e18b45f0.js 1.75kb +0.00b 32.04s +10.78s ⚠️
dist/workerHasher.567cfc57.js 1.62kb +0.00b 32.04s +10.78s ⚠️
dist/heading6.b3b946d1.js 1.49kb +0.00b 32.04s +10.78s ⚠️
dist/heading5.e617db66.js 1.37kb +0.00b 32.04s +10.78s ⚠️
dist/expand.1f17de7f.js 1.27kb +0.00b 32.04s +10.78s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.7220b288.js 1.77mb -6.00b 🚀 19.33s -161.00ms
dist/index.99eb0c51.js 694.58kb -4.00b 🚀 50.93s -709.00ms

Three.js ✅

Timings

Description Time Difference
Cold 6.88s -424.00ms 🚀
Cached 401.00ms +16.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.16s -285.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 6e3ff0c into v2 Aug 29, 2021
@devongovett devongovett deleted the revert-coep branch August 29, 2021 04:52
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (69 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 11, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants