-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maxwell solver example #90
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #90 +/- ##
===========================================
+ Coverage 86.19% 86.28% +0.09%
===========================================
Files 285 293 +8
Lines 20092 20306 +214
===========================================
+ Hits 17319 17522 +203
- Misses 2773 2784 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Made a couple tiny changes, and theres only a couple other things I noticed.
- profilingTips.text - Do we need this?
- The default problem size in setupTet3D.rc is real chunky, even for my workstation GPU. Maybe we can reduce this so it runs reasonably quickly?
I removed the profiling tips file and reduced the size of the box mesh in setupTet3D.rc Are the testMaxwell.py meshes small enough ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The Maxwell solver demos: