Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/collateral swap 2 #369

Open
wants to merge 86 commits into
base: main
Choose a base branch
from
Open

Feat/collateral swap 2 #369

wants to merge 86 commits into from

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Apr 13, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner April 13, 2023 09:03
GopherJ and others added 19 commits April 13, 2023 16:42
Signed-off-by: GopherJ <[email protected]>
* fix: build

Signed-off-by: GopherJ <[email protected]>

* chore: cleanup

Signed-off-by: GopherJ <[email protected]>

* feat: resolve some TODOs

Signed-off-by: GopherJ <[email protected]>

* feat: pass swapAdapter, swapPayload

Signed-off-by: GopherJ <[email protected]>

* fix: stack too deep

Signed-off-by: GopherJ <[email protected]>

* fix: lint

Signed-off-by: GopherJ <[email protected]>

* fix: buy tests

Signed-off-by: GopherJ <[email protected]>

* fix: accept bid tests

Signed-off-by: GopherJ <[email protected]>

* chore: remove unused params

Signed-off-by: GopherJ <[email protected]>

* chore: remove unused swapProvider

Signed-off-by: GopherJ <[email protected]>

* fix: typo

Signed-off-by: GopherJ <[email protected]>

* fix: typo & check srcToken

Signed-off-by: GopherJ <[email protected]>

* chore: emit missing event

Signed-off-by: GopherJ <[email protected]>

* fix: basic borrow and swap

Signed-off-by: GopherJ <[email protected]>

* feat: add missing buy tests

Signed-off-by: GopherJ <[email protected]>

* fix: lint

Signed-off-by: GopherJ <[email protected]>

* feat: support non-listed token with underlying asset address function

Signed-off-by: GopherJ <[email protected]>

---------

Signed-off-by: GopherJ <[email protected]>
* fix: build

Signed-off-by: GopherJ <[email protected]>

* chore: cleanup

Signed-off-by: GopherJ <[email protected]>

* feat: resolve some TODOs

Signed-off-by: GopherJ <[email protected]>

* feat: pass swapAdapter, swapPayload

Signed-off-by: GopherJ <[email protected]>

* fix: stack too deep

Signed-off-by: GopherJ <[email protected]>

* fix: lint

Signed-off-by: GopherJ <[email protected]>

* fix: buy tests

Signed-off-by: GopherJ <[email protected]>

* fix: accept bid tests

Signed-off-by: GopherJ <[email protected]>

* chore: remove unused params

Signed-off-by: GopherJ <[email protected]>

* chore: remove unused swapProvider

Signed-off-by: GopherJ <[email protected]>

* fix: typo

Signed-off-by: GopherJ <[email protected]>

* fix: typo & check srcToken

Signed-off-by: GopherJ <[email protected]>

* chore: emit missing event

Signed-off-by: GopherJ <[email protected]>

* fix: basic borrow and swap

Signed-off-by: GopherJ <[email protected]>

* feat: add missing buy tests

Signed-off-by: GopherJ <[email protected]>

* fix: lint

Signed-off-by: GopherJ <[email protected]>

* feat: support non-listed token with underlying asset address function

Signed-off-by: GopherJ <[email protected]>

* feat: ptoken support for collateral swap

Signed-off-by: GopherJ <[email protected]>

---------

Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
@GopherJ GopherJ requested a review from a team as a code owner April 23, 2023 09:24
Signed-off-by: GopherJ <[email protected]>
GopherJ added 21 commits July 7, 2023 09:11
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Signed-off-by: GopherJ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants