Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use balance diff mode while decreasing liquidity #315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Jan 10, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner January 10, 2023 12:05
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #315 (3bf9370) into main (042e0cb) will increase coverage by 0.06%.
The diff coverage is 69.49%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   74.88%   74.94%   +0.06%     
==========================================
  Files          82       83       +1     
  Lines        3711     3788      +77     
  Branches      697      710      +13     
==========================================
+ Hits         2779     2839      +60     
- Misses        566      573       +7     
- Partials      366      376      +10     
Impacted Files Coverage Δ
...ontracts/protocol/tokenization/NTokenUniswapV3.sol 3.84% <5.00%> (-0.33%) ⬇️
contracts/misc/AutoCompoundApe.sol 88.52% <40.00%> (-4.34%) ⬇️
...ntracts/protocol/tokenization/NTokenApeStaking.sol 74.19% <80.00%> (+0.11%) ⬆️
contracts/protocol/tokenization/NTokenBAKC.sol 82.14% <82.14%> (ø)
contracts/protocol/pool/PoolApeStaking.sol 85.26% <85.18%> (-0.82%) ⬇️
...rotocol/tokenization/libraries/ApeStakingLogic.sol 90.90% <100.00%> (+0.90%) ⬆️
...ocol/libraries/configuration/UserConfiguration.sol 46.34% <0.00%> (-2.44%) ⬇️
contracts/protocol/pool/PoolParameters.sol 70.76% <0.00%> (-1.54%) ⬇️
...racts/protocol/libraries/logic/ValidationLogic.sol 62.14% <0.00%> (+0.46%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants