-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump alloy #10537
chore(deps): bump alloy #10537
Conversation
97b366a
to
ea681f3
Compare
ea681f3
to
70cfb28
Compare
yeah we can leave this None for now, we need to add support for this separately |
@@ -94,7 +95,7 @@ where | |||
From<<Node::Engine as PayloadTypes>::BuiltPayload> + PayloadEnvelopeExt, | |||
AddOns::EthApi: EthApiSpec + EthTransactions + TraceExt, | |||
<AddOns::EthApi as EthApiTypes>::NetworkTypes: | |||
Network<TransactionResponse = alloy_rpc_types::Transaction>, | |||
Network<TransactionResponse = WithOtherFields<alloy_rpc_types::Transaction>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emhane how feasible do you think using OpNetwork is after this pr?
203e4ec
to
a5cd0b1
Compare
lint job is failing because should I just disable this check for that case? |
I think we can cheat here by doing
|
prefer using longer path...valuable to recognise all deps when reading a file for experienced devs |
revm released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bump alloy to latest commit. This currently uses several patches:
log.position
for geth traces revm-inspectors#184Main changes:
alloy_rpc_types_eth::Transaction
no more hasother
field, so I've updated code that relies on it to useWithOtherFields<Transaction>
instead. Also updatedNetworkTypes
value toAnyNetwork
.Compact
impl forBytecode
. It was incorrect for EOF and needed an impl for EIP7702 caseThere's now
deposit_receipt_version
field onOptimismTransactionFields
. I've left it asNone
for now, not sure how we should populate it