Enhance explain #146
Enhance explain #146
Conversation
|
It depends on sqlparser apache/datafusion-sqlparser-rs#1426. Awaiting the next release of the library. |
src/hooks/query.rs
Outdated
|
|
||
| macro_rules! fallback_warning { | ||
| ($msg:expr) => { | ||
| warning!("This query was not fully pushed down to DuckDB because DuckDB returned an error. Query times may be impacted. If you would like to see this query pushed down, please submit a request to https://github.com/paradedb/paradedb/issues with the following context:\n{}", $msg); |
There was a problem hiding this comment.
this should say paradedb/pg_analytics instead of paradedb/paradedb
|
Should this be based off of #140? |
kysshsy
force-pushed
the
enhance_explain
branch
from
c6f38a0
to
cc4262f
Compare
| Ok(r) | ||
| })?; | ||
|
|
||
| Ok(rows.join("")) |
There was a problem hiding this comment.
This just adds a new row right?
| Style::Postgres => { | ||
| let mut output = format!("DuckDB Scan: {}\n", query); | ||
| if state.analyze { | ||
| let start_time = Instant::now(); | ||
| set_search_path_by_pg()?; | ||
| connection::execute(&query, [])?; | ||
| let duration = start_time.elapsed(); | ||
| output += &format!( | ||
| "Execution Time: {:.3} ms\n", | ||
| duration.as_micros() as f64 / 1_000.0 | ||
| ); | ||
| } | ||
| output | ||
| } | ||
| Style::Duckdb => { |
There was a problem hiding this comment.
This is cool. What do you see as the use case for supporting both styles? Is there anything the DuckDB style offers that can't be in a single style?
I don't want to increase cognitive load on the user. Ideally, they wouldn't need to pass any setting to EXPLAIN if they can avoid it. What do you think?
There was a problem hiding this comment.
Could you please provide output examples for all the style/options you are adding here? I.e. what the query looks like, and what the output looks like? I'd like to build a better understanding of what this will look like before we merge anything.
Also some tests, but I understand this PR isn't ready for review yet.
Ticket(s) Closed
EXPLAINStatement: Addanalyzeoption, Supportstyleoption #124What
Why
How
Support the ANALYZE option: add a timer to record the actual execution time.
Support the STYLE option: Provide the query plan and execution time in DuckDB style.
Tests