-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support prepare pushdown #140
Open
kysshsy
wants to merge
13
commits into
paradedb:dev
Choose a base branch
from
kysshsy:utility_prepare
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+564
−124
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
14a452b
feat: support prepare statement
kysshsy 365b16e
test: add prepare test
kysshsy ce973a6
feat: add Query plan check
kysshsy 074ea2c
fix: run fmt
kysshsy 2d17a6c
feat: change the way to get cached plan
kysshsy 10421f2
fix: run fmt
kysshsy 1d0133c
fix: pg13 compile
kysshsy a5ad5db
fix: fix compile
kysshsy 44cd8c3
fix: replan in Duckdb when search_path changed
kysshsy 43909d1
fix: pg17 function name change
kysshsy e055dfa
test: add search path test
kysshsy 63cf73f
fix: change warning message url
kysshsy 6b96f8c
fix: fix pg13 compile
kysshsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright (c) 2023-2024 Retake, Inc. | ||
// | ||
// This file is part of ParadeDB - Postgres for Search and Analytics | ||
// | ||
// This program is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU Affero General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
// | ||
// This program is distributed in the hope that it will be useful | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU Affero General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU Affero General Public License | ||
// along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
use std::ffi::CString; | ||
|
||
use anyhow::Result; | ||
use pgrx::{error, pg_sys}; | ||
|
||
use super::parse_query_from_utility_stmt; | ||
use crate::hooks::query::{get_query_relations, is_duckdb_query}; | ||
|
||
pub fn explain_query( | ||
query_string: &core::ffi::CStr, | ||
stmt: *mut pg_sys::ExplainStmt, | ||
dest: *mut pg_sys::DestReceiver, | ||
) -> Result<bool> { | ||
let query = unsafe { (*stmt).query as *mut pg_sys::Query }; | ||
|
||
let query_relations = get_query_relations(unsafe { (*query).rtable }); | ||
if unsafe { (*query).commandType } != pg_sys::CmdType::CMD_SELECT | ||
|| !is_duckdb_query(&query_relations) | ||
{ | ||
return Ok(true); | ||
} | ||
|
||
if unsafe { !(*stmt).options.is_null() } { | ||
error!("the EXPLAIN options provided are not supported for DuckDB pushdown queries."); | ||
} | ||
|
||
unsafe { | ||
let tstate = pg_sys::begin_tup_output_tupdesc( | ||
dest, | ||
pg_sys::ExplainResultDesc(stmt), | ||
&pg_sys::TTSOpsVirtual, | ||
); | ||
let query = format!( | ||
"DuckDB Scan: {}", | ||
parse_query_from_utility_stmt(query_string)? | ||
); | ||
let query_c_str = CString::new(query)?; | ||
|
||
pg_sys::do_text_output_multiline(tstate, query_c_str.as_ptr()); | ||
pg_sys::end_tup_output(tstate); | ||
} | ||
|
||
Ok(false) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in understanding that this is fixed in your other PR? Or are there other options that won't be supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've just moved the code. I will implement options support in another PR.