Update compressed gem size based on rubygems.org stats #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEvelyn
commented
Sep 17, 2024
| @@ -17,7 +17,7 @@ _No breaking changes!_ | |||
|
|
|||
| **Gem enhancements:** | |||
|
|
|||
| - Reduced gem size from 173 kB compressed (312 kB unpacked) to 20 kB (68 kB unpacked) [[#345](https://github.com/panorama-ed/memo_wise/pull/345)] | |||
| - Reduced gem size from 173 kB compressed (312 kB unpacked) to 18.5 kB (68 kB unpacked) [[#345](https://github.com/panorama-ed/memo_wise/pull/345)] | |||
There was a problem hiding this comment.
Not sure why this was different on my machine, but 173 kB and 18.5 kB are the sizes officially reported by rubygems.org, and 312 kB and 68 kB are the sizes I get when I download the gem from rubygems.org and then run du -sh /path/to/.gem/ruby/3.3.3/gems/memo_wise-1.9.0 (or -1.10.0).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
ms-ati
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning