-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.10.0 #346
Version 1.10.0 #346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
|
||
**Gem enhancements:** | ||
|
||
- Reduced unzipped gem size from 312 kB to 68 kB [[#345](https://github.com/panorama-ed/memo_wise/pull/345)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagliala I wanted to double-check your numbers but got different results. Here's what I did:
$ gem install memo_wise # installs v1.9.0
$ gem info memo_wise
$ du -sh /path/to/ruby/3.3.3/gems/memo_wise-1.9.0
312K /Users/jevelyn/.gem/ruby/3.3.3/gems/memo_wise-1.9.0
$ gem build memo_wise.gemspec
$ mv memo_wise-1.10.0.gem ~/Downloads
$ gem unpack ~/Downloads/memo_wise-1.10.0.gem
$ du -sh ~/Downloads/memo_wise-1.10.0
68K ./memo_wise-1.10.0/
did I do something incorrectly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacobEvelyn sorry, I just realized that "unzipped" is incorrect
I was referring to the compressed version, I've noticed it was "too big for the source code" here:
https://rubygems.org/gems/memo_wise
Screen attached:
This will change to 19 KB after the new release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I see it as 20 kB on my machine for some reason (probably slight differences around the CHANGELOG updates for v1.10.0); I'll change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
953dde7
to
5181eb3
Compare
Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.md
and update this PRCHANGELOG.md
, add an entry following Keep a Changelog guidelines with semantic versioning