Fixed a bug that overwrote existing self.extended method definitions.

[alpaca-tc]

There is a hack that dynamically defines self.extended when memo_wise is called, but there was a bug that did not consider the case where an existing self.extended existed, so this has been fixed.

Before merging:

• Copy the table printed at the end of the latest benchmark results into the README.md and update this PR
• If this change merits an update to CHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aae31f2) 100.00% compared to head (20fe5fe) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          179       183    +4     
  Branches        88        88           
=========================================
+ Hits           179       183    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JacobEvelyn]

Thanks @alpaca-tc ! This looks great to me.

Would you mind rebasing your branch on top of the latest main, and while you're at it updating the README.md benchmark results to these from the CI run for this PR:

|Method arguments|`Dry::Core`\* (1.0.1)|`Memery` (1.5.0)|
|--|--|--|
|`()` (none)|0.59x|3.65x|
|`(a)`|1.49x|8.38x|
|`(a, b)`|1.21x|6.55x|
|`(a:)`|1.43x|13.14x|
|`(a:, b:)`|1.20x|10.32x|
|`(a, b:)`|1.18x|10.10x|
|`(a, *args)`|0.79x|1.61x|
|`(a:, **kwargs)`|0.75x|1.97x|
|`(a, *args, b:, **kwargs)`|0.67x|1.37x|

|Method arguments|`DDMemoize` (1.0.0)|`Memoist` (0.16.2)|`Memoized` (1.1.1)|`Memoizer` (1.0.3)|
|--|--|--|--|--|
|`()` (none)|23.10x|2.28x|23.77x|2.69x|
|`(a)`|21.57x|14.28x|20.61x|12.05x|
|`(a, b)`|19.05x|13.55x|17.83x|11.68x|
|`(a:)`|30.29x|23.54x|25.22x|21.69x|
|`(a:, b:)`|27.79x|22.83x|23.78x|21.08x|
|`(a, b:)`|26.61x|21.40x|21.63x|19.81x|
|`(a, *args)`|3.16x|2.26x|3.08x|1.97x|
|`(a:, **kwargs)`|2.74x|2.25x|2.47x|2.10x|
|`(a, *args, b:, **kwargs)`|2.18x|1.84x|1.93x|1.73x|

[JacobEvelyn]

Actually it looks like GitHub gives me permission to edit your branch so I'm just making those changes. Hope that's okay!

[JacobEvelyn]

@ms-ati would love your review here! (And also #326 )

[ms-ati]

Hello @alpaca-tc thank you for this!

Can we add a test asserting, in addition to the fact that we call the previously defined Module#extended, that we also are actually memoizing the call to no_args? I suspect that was intended by maybe not finished?

[alpaca-tc]

Added and force-pushed 👍

[ms-ati]

Thank you so much! LGTM