Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated gitbook cli with mdbook #1226

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Replace deprecated gitbook cli with mdbook #1226

merged 2 commits into from
Jul 9, 2024

Conversation

kachick
Copy link
Collaborator

@kachick kachick commented Jun 25, 2024

Resolves #870

If we use nix in #869,
the dependencies can be injected as nix-shell --packages mdbook mdbook-plantuml plantuml

@kachick kachick requested a review from pankona as a code owner June 25, 2024 06:48
Comment on lines +3 to +4
- Use GRPC for communication between front and daemon
- Use GRPC for communication between daemon and datastore
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this file for adjusting mdbook structure restriction.
Please update the content if you need.

@pankona
Copy link
Owner

pankona commented Jun 26, 2024

@kachick Thank you! I will check this soon!

Copy link
Owner

@pankona pankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

時代は mdbook であったか

@pankona pankona merged commit 7a1b329 into master Jul 9, 2024
6 checks passed
@pankona pankona deleted the mdBook branch July 9, 2024 12:20
@pankona
Copy link
Owner

pankona commented Jul 9, 2024

@kachick Thank you!

@kachick
Copy link
Collaborator Author

kachick commented Jul 9, 2024

📖 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitBook CLI is deprecated
2 participants