Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Additional parameters for get_project_tasks #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p4r4noj4
Copy link

Hey!
I really like your AsanaAPI wrapper for Python, however I had performance issues, as I had to do manual checking for what's completed and had to get full information for each task one by one (which, as you can imagine, causes lots of network traffic). I found that the API allows to do some checking (completed/not completed) on the server side and that you can expand information by default. I made some simple changes so that those two things can be done through your awesome wrapper. I would be super-happy if you could integrate them to your project!

Cheers,
Igor

@pandemicsyn
Copy link
Owner

Sorry it took me so long to get around this. I don't really use Asana anymore in my $DAYJOB. Should we perhaps default to include_completed=False ?

@p4r4noj4
Copy link
Author

Hey! I thought it would be good to have include_completed default to False, but at the same time I wanted everything to be consistent with how it worked before (that is - it worked as if include_completed was True), but I think we could change that anyway.
Sorry for using wrong github user in commit (was trying to fix that, but git filter-branch was a little bit too much for me and I was afraid it would break something in your repository).

@mudpuddle
Copy link

I have been using this api for a while, and was considering adding the ability to expand the data, on my own. Then i saw this pull request... Is this something that is going to get merged into the master branch? Thanks.

include_completed
full task information
@p4r4noj4
Copy link
Author

With some new knowledge about git I actually managed to squish it all into one commit with right user. Merge please!

@Mte90
Copy link

Mte90 commented Sep 24, 2014

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants