Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Part 1 of 2] Internal feedback from universal router #17

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[Part 1 of 2] Internal feedback from universal router #17

merged 3 commits into from
Sep 20, 2024

Conversation

ChefMist
Copy link
Collaborator

This PR address item i4, i5 and i6

  • i4: remove unused import
  • i5: gas optimization for v3 swap router
  • i6: consider Ownable2Step over ownable

chefburger
chefburger approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@chefburger chefburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChefMist ChefMist merged commit d2764d0 into main Sep 20, 2024
2 checks passed
@ChefMist ChefMist deleted the feat/internal-feedback branch September 20, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chefburger chefburger chefburger approved these changes

@ChefSnoopy ChefSnoopy Awaiting requested review from ChefSnoopy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChefMist @chefburger