Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable zap for all bsc pools and add arb and eth whitelist #10780

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 3, 2024


PR-Codex overview

This PR updates the ZapLiquidityWidget to change its data source from zap-widget to pancakeswap. It also modifies the logic for determining if a pool is part of the ZAP_V3_POOL_ADDRESSES, and it introduces a new structure for managing pool addresses across different chains.

Detailed summary

  • Changed source prop from zap-widget to pancakeswap in ZapLiquidityWidget.tsx.
  • Updated hasZapV3Pool logic in V3FormView/index.tsx to check for whitelisted pools based on pool.chainId.
  • Introduced a new structure for ZAP_V3_POOL_ADDRESSES in zapV3.ts to manage addresses by chain, including specific addresses for ChainId.ETHEREUM and ChainId.ARBITRUM_ONE.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 59d87c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 9:59am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Oct 3, 2024 9:59am
blog ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 9:59am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 9:59am
games ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 9:59am
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 9:59am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 9:59am

import { ChainId } from '@pancakeswap/chains'

export const ZAP_V3_POOL_ADDRESSES: Record<number, string[]> = {
[ChainId.BSC]: [] as string[], // Empty array to whitelist all pools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit counter intuitive. Can we use undefined check instead? Like if not specified then no whitelist restriction

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently If chainid is not specified that means it is not supported for zap, thats why i have added empty array for no zap restriction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants