Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Call update cake apr once instead of per farm when initial load #10774

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 2, 2024


PR-Codex overview

This PR focuses on improving the handling of APR (Annual Percentage Rate) calculations and cache management for different pools in the application, streamlining the code and enhancing performance by optimizing how data is fetched and processed.

Detailed summary

  • Updated the filtering condition for pools in atom.ts.
  • Simplified the fetchMerklApr and fetchCakeApr functions in hooks.ts.
  • Changed query keys to include function names in useQuery calls.
  • Refactored cache handling in fetcher.ts for better readability and efficiency.
  • Removed redundant cache checks and streamlined the setting of cache values.
  • Optimized the getCakePrice function to eliminate unnecessary caching logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:03am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am
blog ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am
games ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:03am

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 7b51da5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil force-pushed the feature/perf_call_update_cake_apr_once_instead_per_farm branch from 6f2570a to 9cf8fc8 Compare October 3, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant