Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invariant crash when adding liquidity #10661

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Sep 10, 2024

It happens some of the no-liquidity/not yet created pools with min/max price on the params

https://pancakeswap.finance/add/0xCF18E4ff8433D32d8d2CC17C7674dbAea01DBA63/BNB/100?minPrice=0.000000000000000000&maxPrice=340256786836388094070642339899681172762.184832000000000000


PR-Codex overview

This PR improves error handling in the RangeSelector component by wrapping logic in try-catch blocks. This ensures that if an error occurs during the calculation of price values, the function will return an empty string instead of potentially causing a runtime error.

Detailed summary

  • Added try-catch blocks around price calculations for leftPrice and rightPrice.
  • Ensured that if an error occurs, the function returns an empty string.
  • Maintained existing logic for returning '0' or '∞' based on tickSpaceLimits.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 8:03am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am
games ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:03am

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 68a8233

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant