Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Experimental Trading #10621

Closed
wants to merge 48 commits into from
Closed

feat: Experimental Trading #10621

wants to merge 48 commits into from

Conversation

chefjackson
Copy link
Collaborator

@chefjackson chefjackson commented Sep 4, 2024


PR-Codex overview

This PR focuses on the removal of various files related to the MMLinkPools functionality, as well as updates to several components and hooks to support new trading features, particularly the introduction of PCSX and X trading types.

Detailed summary

  • Deleted multiple files related to MMLinkPools.
  • Introduced PCSX feature and updated hooks to support it.
  • Added X trading type in logging and components.
  • Updated TransactionList and TransactionListItem components.
  • Modified useSendXOrder for handling new order types.
  • Adjusted utility functions to accommodate new trading logic.

The following files were skipped due to too many changes: packages/universal-router-sdk/src/entities/protocols/pancakeswap.ts, apps/web/src/hooks/useWrapCallback.ts, apps/web/src/views/Swap/x/useWaitForXOrderReceipt.ts, apps/web/src/components/App/Transactions/XTransaction.tsx, apps/web/src/views/Swap/components/AdvancedSwapDetails.tsx, apps/web/src/components/App/Transactions/Transaction.tsx, apps/web/src/components/Menu/GlobalSettings/SettingsModal.tsx, apps/web/src/views/Swap/x/api.ts, apps/web/src/views/Swap/V3Swap/hooks/useAllTypeBestTrade.ts, apps/web/src/views/Swap/x/XSwapTransactionDetail.tsx, apps/web/src/views/Swap/V3Swap/containers/TradeDetails.tsx, apps/web/src/views/Swap/V3Swap/hooks/useSwapBestTrade.ts, apps/web/src/views/Swap/V3Swap/index.tsx, apps/web/src/views/Swap/V3Swap/components/TransactionConfirmSwapContent.tsx, apps/web/src/components/App/Transactions/TransactionsModal.tsx, apps/web/src/views/Swap/V3Swap/containers/SwapCommitButton.tsx, apps/web/src/views/Swap/V3Swap/components/SwapModalFooter.tsx, apps/web/src/hooks/useBestAMMTrade.ts, apps/web/src/views/Swap/V3Swap/containers/ConfirmSwapModal.tsx, packages/localization/src/config/translations.json, apps/web/src/views/Swap/V3Swap/hooks/useConfirmModalState.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 6:41am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am
games ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:41am

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 544afc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chefjackson
Copy link
Collaborator Author

#10740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants