perf: Make history manager provider render only with subscribe #10335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
0xjojoex,
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
ChefBingbong,
thechefpenguin and
chef-eric
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
memoyil
force-pushed
the
feature/pref_make_history_manager_render_with_subscribe
branch
from
a6f12b5
to
9e1c0d8
Compare
memoyil
force-pushed
the
feature/pref_make_history_manager_render_with_subscribe
branch
from
9e1c0d8
to
2798fa0
Compare
memoyil
force-pushed
the
feature/pref_make_history_manager_render_with_subscribe
branch
from
2798fa0
to
24f0d59
Compare
memoyil
force-pushed
the
feature/pref_make_history_manager_render_with_subscribe
branch
from
24f0d59
to
37ae4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historymanager provider and the hook only used in PageNetworkSupportModal therefore no need to re-render whole page when path changes if user is in correct chain
PR-Codex overview
This PR enhances the
HistoryContextby introducing a structured context interface, improving subscriber management, and ensuring proper error handling when using the context. It also refines the history management logic to notify subscribers of changes.Detailed summary
HistoryManagerContextandSubscriberinterfaces.historyManagerContextcreation to use the new interface.useHistoryfor context usage.notifySubscribers,subscribe, andunsubscribefunctions.useHistoryManagerto notify subscribers on history changes.