Skip to content

Commit

Permalink
chore: zksync banner adjustment (#7434)
Browse files Browse the repository at this point in the history
<!--
Before opening a pull request, please read the [contributing
guidelines](https://github.com/pancakeswap/pancake-frontend/blob/develop/CONTRIBUTING.md)
first
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 182d11c</samp>

### Summary
🗑️🎨📱

<!--
1. 🗑️ - This emoji conveys the idea of deleting or removing something,
which is what the change does to the translation key "CTA".
2. 🎨 - This emoji conveys the idea of improving the appearance or design
of something, which is what the change does to the zkSync banner color.
3. 📱 - This emoji conveys the idea of adapting or optimizing something
for mobile devices, which is what the change does to the zkSync button
text.
-->
This pull request enhances the zkSync banner on the home page and
removes an unused translation key. It makes the banner more appealing
and responsive for mobile users and cleans up the `translations.json`
file.

> _`CTA` key gone_
> _zkSync banner shines brighter_
> _Spring cleaning the code_

### Walkthrough
* Add white color to banner title for better contrast and visibility
([link](https://github.com/pancakeswap/pancake-frontend/pull/7434/files?diff=unified&w=0#diff-96c8c592cb95cdeee4b804c7ef0446a64d589ec8dbd9dd9fc93826c5da873dcbR53))
* Change button text to "Start Now" for mobile devices and remove unused
translation key
([link](https://github.com/pancakeswap/pancake-frontend/pull/7434/files?diff=unified&w=0#diff-96c8c592cb95cdeee4b804c7ef0446a64d589ec8dbd9dd9fc93826c5da873dcbL123-R124),
[link](https://github.com/pancakeswap/pancake-frontend/pull/7434/files?diff=unified&w=0#diff-eb2ab983e2cefc22516cb7814c86346f4b2bd2b971980952868173095d48f459L2615-R2615))
  • Loading branch information
Chef-Yogi authored Jul 27, 2023
1 parent 1c18099 commit c2acf32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion apps/web/src/views/Home/components/Banners/ZksyncBanner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const Title = styled.div`
line-height: 98%;
padding-right: 80px;
margin-bottom: 20px;
color: ${({ theme }) => theme.colors.white};
${({ theme }) => theme.mediaQueries.lg} {
font-size: 32px;
Expand Down Expand Up @@ -120,7 +121,7 @@ export const ZksyncBanner = () => {
>
<StyledButtonLeft scale={['xs', 'sm', 'md']} style={{ borderRadius: isMobile && '20px' }}>
<Text bold fontSize={['12px', '16px']} mr="4px">
{isMobile ? t('CTA') : t('Get Started')}
{isMobile ? t('Start Now') : t('Get Started')}
</Text>
<OpenNewIcon color="white" />
</StyledButtonLeft>
Expand Down
3 changes: 1 addition & 2 deletions packages/localization/src/config/translations.json
Original file line number Diff line number Diff line change
Expand Up @@ -2612,6 +2612,5 @@
"Round #%round% | %startTime% - %endTime%": "Round #%round% | %startTime% - %endTime%",
"Swap and Provide Liquidity on zkSync Era Now": "Swap and Provide Liquidity on zkSync Era Now",
"PancakeSwap Now Live on zkSync Era!": "PancakeSwap Now Live on zkSync Era!",
"Zksync Lormips LIVE!": "Zksync Lormips LIVE!",
"CTA": "CTA"
"Zksync Lormips LIVE!": "Zksync Lormips LIVE!"
}

2 comments on commit c2acf32

@vercel
Copy link

@vercel vercel bot commented on c2acf32 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

uikit – ./packages/uikit

uikit-git-develop.pancake.run
uikit.pancake.run

@vercel
Copy link

@vercel vercel bot commented on c2acf32 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.