Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(Menu): Display NewTag in the externalLink (#8491)
<!-- Before opening a pull request, please read the [contributing guidelines](https://github.com/pancakeswap/pancake-frontend/blob/develop/CONTRIBUTING.md) first --> <!-- copilot:all --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at 9bc4021</samp> ### Summary 🎨🐛🚀 <!-- 1. 🎨 - This emoji is often used to indicate code style or formatting improvements, such as refactoring, renaming, or reorganizing code. In this case, the `DropdownMenu` component was refactored to improve code readability and consistency, which could be considered a style improvement. 2. 🐛 - This emoji is often used to indicate bug fixes or error handling, such as fixing a missing closing tag, a typo, or a logic error. In this case, the `DropdownMenu` component had a missing closing tag for the `ul` element, which could cause rendering issues or invalid HTML, so fixing it could be considered a bug fix. 3. 🚀 - This emoji is often used to indicate performance improvements or new features, such as adding a new component, a new functionality, or a new optimization. In this case, the `DropdownMenu` component added a `Flex` component to align the menu items, which could be considered a new feature or a UI enhancement. --> Refactored the `DropdownMenu` component and fixed a bug in `packages/uikit`. > _The `DropdownMenu` was a mess_ > _With a tag that it failed to address_ > _So it got a refactor_ > _And a `Flex` benefactor_ > _Now it looks and behaves with finesse_ ### Walkthrough * Reorder imports alphabetically and move `LinkStatus` component up to match styles file ([link](https://github.com/pancakeswap/pancake-frontend/pull/8491/files?diff=unified&w=0#diff-d5748bbba35280005dd7f9dae278f09e2205045d50e8230a00c8f9fd24d73225L2-R4), [link](https://github.com/pancakeswap/pancake-frontend/pull/8491/files?diff=unified&w=0#diff-d5748bbba35280005dd7f9dae278f09e2205045d50e8230a00c8f9fd24d73225L12-R13)) * Wrap `MenuItemContent` in `Flex` component to align label and status horizontally and add closing tag ([link](https://github.com/pancakeswap/pancake-frontend/pull/8491/files?diff=unified&w=0#diff-d5748bbba35280005dd7f9dae278f09e2205045d50e8230a00c8f9fd24d73225L108-R108), [link](https://github.com/pancakeswap/pancake-frontend/pull/8491/files?diff=unified&w=0#diff-d5748bbba35280005dd7f9dae278f09e2205045d50e8230a00c8f9fd24d73225L115-R115)) * Replace `label` prop with `MenuItemContent` variable to reuse rendering logic ([link](https://github.com/pancakeswap/pancake-frontend/pull/8491/files?diff=unified&w=0#diff-d5748bbba35280005dd7f9dae278f09e2205045d50e8230a00c8f9fd24d73225L157-R157)) Before: ![image](https://github.com/pancakeswap/pancake-frontend/assets/109973128/9b459dfc-d83a-4440-ac26-c75f320b54d1) After: ![image](https://github.com/pancakeswap/pancake-frontend/assets/109973128/f1c1ef6a-721e-4e36-975b-1558a1726659) --------- Co-authored-by: Woody <[email protected]>
- Loading branch information
363e4cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
uikit – ./packages/uikit
uikit.pancake.run
uikit-git-develop.pancake.run