Add freshness to auth tokens #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 36 36
Lines 4621 4622 +1
=======================================
+ Hits 4549 4550 +1
Misses 72 72 ☔ View full report in Codecov by Sentry. |
This enables us-setup to be totally functional with auth tokens (not requiring a session cookie). - Authentication tokens now carry freshness information - namely the timestamp that the client/user successfully authenticated. - Both sessions and auth tokens place the timestamp into a request global - fs_paa - @auth_required() freshness checking looks at the request global - a config parameter SECURITY_FRESHNESS_ALLOW_AUTH_TOKEN can be set to False which forces any request using an auth token to be 'not-fresh' (the previous behavior). - Removed code for freshness 'within' == 0 - which was a hack for testing - we have better testing utilities now. - fixed/improved example for unified signin. - doc improvements...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us-setup to be totally functional with auth tokens (not requiring a session cookie).