Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /reset and /confirm w.r.t. GENERIC_RESPONSES and additional f… #815

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jul 17, 2023

…orm args.

Title says it all - very confusing (UX) results when adding a form arg (e.g. captcha) so the above forms and having an error.

closes #814

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3bbd996) 98.16% compared to head (e925dbd) 98.16%.

❗ Current head e925dbd differs from pull request most recent head c433937. Consider uploading reports for the commit c433937 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          34       34           
  Lines        4460     4461    +1     
=======================================
+ Hits         4378     4379    +1     
  Misses         82       82           
Impacted Files Coverage Δ
flask_security/forms.py 99.21% <ø> (ø)
flask_security/views.py 98.78% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…orm args.

Title says it all - very confusing (UX) results when adding a form arg (e.g. captcha) so the above forms and having an error.

closes #814
@jwag956 jwag956 merged commit bf5a31f into master Jul 17, 2023
13 checks passed
@jwag956 jwag956 deleted the val814 branch July 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Generic responses lead to UX degradation
1 participant