Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SECURITY_DEPRECATED_HASHING_SCHEMES #1003

Closed
wants to merge 1 commit into from

Conversation

savchenko
Copy link

Make configuration explicit. I also wonder if it's worth setting by default:

SECURITY_DEPRECATED_HASHING_SCHEMES = ["auto"]
SECURITY_HASHING_SCHEMES = ["sha256_crypt"]

Make configuration explicit.
Copy link
Collaborator

@jwag956 jwag956 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we just change 'SECURITY_DEPRECATED_HASHING_SCHEMES to ["auto"] - that seems the best/easiest. Given current default config - that change actually wouldn't change anything.

@savchenko
Copy link
Author

savchenko commented Jul 8, 2024

How about we just change 'SECURITY_DEPRECATED_HASHING_SCHEMES to ["auto"] - that seems the best/easiest.

Sounds good. Just need to make sure that sha256_crypt is the first one, order is important.

Maybe include link https://passlib.readthedocs.io/en/stable/lib/passlib.context.html as well, I had to read it to comprehend what's actually going on.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (25ad68d) to head (ba007b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          37       37           
  Lines        4777     4777           
=======================================
  Hits         4705     4705           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwag956
Copy link
Collaborator

jwag956 commented Jul 12, 2024

fixed with #1009

@jwag956 jwag956 closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants