(Refactor) : Removed patient bills filter and fixed patient search css issue #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amosmachora
changed the title
donaldkibet
requested changes
Aug 15, 2024
packages/esm-billing-app/src/billable-services/bill-manager/bill-manager.component.tsx
Outdated
Show resolved
Hide resolved
...s/esm-billing-app/src/past-patient-bills/patient-bills-dashboard/patient-bills-dashboard.tsx
Outdated
Show resolved
Hide resolved
| @@ -50,39 +45,30 @@ const PastPatientBills: React.FC<PatientBillsProps> = ({ patientUuid, bills, set | |||
| {bill.dateCreated} | |||
| </ConfigurableLink> | |||
| ), | |||
| billableService: extractString(bill.billingService), | |||
| billableService: extractBillableServiceReadableString(bill.billingService), | |||
There was a problem hiding this comment.
There is an existing function name extractString we might want to improve the naming of it. cc @ojwanganto we should not be doing this on the frontend. We will need to improve the backend response for this
donaldkibet
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
In this PR I have fixed the issue whereby the
patient-billscomponent filtered all bills that were not paid. Currently the UI now shows all the bills as requested by @ojwanganto .Also I have made some UI improvements to handle better
no-patient-selected,errorsandloadingstates. Also I have fixed the search issue that broke the patient search results.@donaldkibet please see here. The reason I had to use
!importantis because I did not want to open another PR on the community over the same issue as the one I had a few weeks ago.Also I have fixed another issue I came across whereby if a bill had multiple line items the UI would only show one line item in the UI thereby misleading the user.
Screenshots
Search results
Billable services
None.
Related Issue
None.
Other
None.