OUT-46 Integrate APIs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sajjanstha
reviewed
Feb 2, 2024
sajjanstha
reviewed
Feb 2, 2024
| if (!clientId) { | ||
| respondError('Missing client Id', 422); | ||
| } | ||
| const copilotClient = new CopilotAPI(z.string().parse(token)); |
There was a problem hiding this comment.
why this is not inside try/catch?
src/components/customFieldAccessTable/CustomFieldAccessTable.tsx
Outdated
Show resolved
Hide resolved
sajjanstha
reviewed
Feb 8, 2024
src/app/views/Sidebar.tsx
Outdated
|
|
||
| export const Sidebar = () => { | ||
| const appState = useAppState(); | ||
|
|
||
| const handleMutableSettings = (selected: boolean, type: string) => { | ||
| if (!selected) { | ||
| if (type === 'profile_settings') { | ||
| if (type === ProfileLinks.ProfileSetting) { | ||
| const newSettings = appState?.mutableSettings.filter((el: string) => el !== type); |
There was a problem hiding this comment.
Seems like the underlying logic for both these conditions are same, why the type check at all?
There was a problem hiding this comment.
d0ed649 commit removes unnecessary if/else comparision @sajjanstha
sajjanstha
reviewed
Feb 8, 2024
src/app/views/Sidebar.tsx
Outdated
| const newSettings = appState?.mutableSettings.filter((el: string) => el !== type); | ||
| appState?.setAppState((prev) => ({ ...prev, mutableSettings: newSettings })); | ||
| } | ||
| } | ||
| if (selected) { | ||
| if (type === 'profile_settings') { | ||
| if (type === ProfileLinks.ProfileSetting) { |
There was a problem hiding this comment.
d0ed649 commit resolves this @sajjanstha
|
I updated the code to use server action in this commit - b6d7909, but there was an error while revalidateTag only in the production. I am not sure why. So for now I have reverted the server actions back. @saugatmaharjan |
saugatmaharjan
approved these changes
Feb 8, 2024
|
leaving server action to do in another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Ticket
Integrate APIs
The main changes are