-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating 90 degree angle on adjacent lanes with different lane heights #93
Open
ge25bec
wants to merge
13
commits into
pageldev:master
Choose a base branch
from
ge25bec:fix/adjacent-lane-height-transition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Generating 90 degree angle on adjacent lanes with different lane heights #93
ge25bec
wants to merge
13
commits into
pageldev:master
from
ge25bec:fix/adjacent-lane-height-transition
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses additional height parameter
- Lane::get_height_offset(const double s) - overload for LaneSection::get_lane_id using height value
Adjacent lanes with different lane heights now have additional vertices in the mesh, to generate a 90 degree transition between them
uses additional height parameter
- Lane::get_height_offset(const double s) - overload for LaneSection::get_lane_id using height value
Adjacent lanes with different lane heights now have additional vertices in the mesh, to generate a 90 degree transition between them
- added s values of inner lane height offsets to mesh generation of the outer lane
…ion' into fix/adjacent-lane-height-transition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #92
It seems the problem is that
Road::get_surface_pt
usesLaneSection::get_lane_id
, which doesn't take a height parameter. For a point on the border of two lanes, the method will always create a vertex with the outer height of the inner lane. I changedRoad::get_lane_mesh
so it now generates another vertex, which has the inner height of the outer lane and is linked in the mesh accordingly.