fix: add ‹/usr/local› to ‹PYTHONPATH› #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
nforro
approved these changes
May 30, 2024
lbarcziova
approved these changes
May 30, 2024
With regards to the change that occured in between 3.4.1 and 3.5.0 releases of Fedora Messaging, it is not possible to import consumer callback from ‹/usr/local/› installed Python module, which is the default for global installation of packages via pip. Given the fact that there needs to be hardcoded Python version in the path, I hate this solution. When trying out ‹--callback-file›, I've been hit with the same import issue, as Celery is installed via pip too, cause it hasn't been released to EPEL9 even after a year of requesting this via RHBZ#2032543. Trying out the “hack”¹ from similar project resulted in failure too, as the current working directory isn't included in the path either. So much for the ecosystem and easy to use… ¹ https://gitlab.com/CentOS/Integration/gitlab-webhooks/-/merge_requests/1/diffs?commit_id=1bc3b2f8c2598dd6a24c70f149b3cc683eaf37b1 Related to fedora-infra/fedora-messaging#364 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
fix/importing-consumerino
branch
from
ea34090
to
db1b9f5
Compare
Co-authored-by: Laura Barcziová <[email protected]> Co-authored-by: Nikola Forrò <[email protected]> Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
fix/importing-consumerino
branch
from
db1b9f5
to
addcd47
Compare
Maybe we could change the pip installation path (possibly with |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 55s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 49s |
softwarefactory-project-zuul
bot
merged commit d6f474d
into
packit:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regards to the change that occured in between 3.4.1 and 3.5.0 releases of Fedora Messaging, it is not possible to import consumer callback from ‹/usr/local/› installed Python module, which is the default for global installation of packages via pip.
Given the fact that there needs to be hardcoded Python version in the path, I hate this solution.
When trying out ‹--callback-file›, I've been hit with the same import issue, as Celery is installed via pip too, cause it hasn't been released to EPEL9 even after a year of requesting this via RHBZ#2032543.
Trying out the “hack”¹ from similar project resulted in failure too, as the current working directory isn't included in the path either.
So much for the ecosystem and easy to use…
¹ https://gitlab.com/CentOS/Integration/gitlab-webhooks/-/merge_requests/1/diffs?commit_id=1bc3b2f8c2598dd6a24c70f149b3cc683eaf37b1
Related to fedora-infra/fedora-messaging#364