Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ./ when getting file in GitLab #844

Merged
merged 1 commit into from
Mar 4, 2024
+632 −0
Merged

Remove ./ when getting file in GitLab #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ogr/services/gitlab/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# SPDX-License-Identifier: MIT

import logging
import os
from typing import Any, Optional, Union

import gitlab
Expand Down Expand Up @@ -361,6 +362,8 @@ def get_branches(self) -> list[str]:

def get_file_content(self, path, ref=None) -> str:
ref = ref or self.default_branch
# GitLab cannot resolve './'
path = os.path.normpath(path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking for this function, but everything I managed to find on the Path class was impure /o And this (at least documentation doesn't say a thing) is pure, but under the os module /o\ This language is a mess…

try:
file = self.gitlab_repo.files.get(file_path=path, ref=ref)
return file.decode().decode()
Expand Down
Loading
Loading