Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for percent signs #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-phylum
Copy link
Contributor

@matt-phylum matt-phylum commented Nov 20, 2023

This PR adds a simple test that percent signs are correctly encoded and decoded in all parts of a PURL. Some implementations don't correctly handle percent encoding in all allowed positions (giterlizzi/perl-URI-PackageURL, maennchen/purl, package-url/packageurl-ruby, package-url/packageurl-swift, sonatype/package-url-java) and some implementations don't encode percent signs (althonos/packageurl.rs, anchore/packageurl-go, phylum-dev/purl).

matt-phylum added a commit to phylum-dev/purl that referenced this pull request Nov 20, 2023
matt-phylum added a commit to phylum-dev/purl that referenced this pull request Nov 22, 2023
* encode percent signs

* use same test as package-url/purl-spec#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants