Add fontFamily options #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolankramer
reviewed
Aug 16, 2024
Comment on lines
+30
to
+38
| QColor NormalBoundaryColor; | ||
| QColor SelectedBoundaryColor; | ||
| QColor GradientColor0; | ||
| QColor GradientColor1; | ||
| QColor GradientColor2; | ||
| QColor GradientColor3; | ||
| QColor ShadowColor; | ||
| QColor FontColor; | ||
| QColor FontColorFaded; |
There was a problem hiding this comment.
Please revert changes like these. There is no need to change these lines of code.
As a word of advice - it is usually desirable to only change code that needs to be changed to address the PR. This avoids causing confusion/overload when others review the change.
Additionally, stylistic coding is really up to repo owner as of now. And it seems like a single space between type and variable name is the overall style (and it typically is).
nolankramer
suggested changes
Aug 16, 2024
Comment on lines
+40
to
+51
| QColor ConnectionPointColor; | ||
| QColor FilledConnectionPointColor; | ||
|
|
||
| QColor WarningColor; | ||
| QColor ErrorColor; | ||
|
|
||
| float PenWidth; | ||
| float HoveredPenWidth; | ||
|
|
||
| float ConnectionPointDiameter; | ||
|
|
||
| float Opacity; |
There was a problem hiding this comment.
Please revert adding these additional spaces.
| @@ -14,6 +14,7 @@ | |||
| "ShadowColor": [20, 20, 20], | |||
| "FontColor" : "white", | |||
| "FontColorFaded" : "gray", | |||
| "FontFamily": "Microsoft YaHei", | |||
There was a problem hiding this comment.
The default font should be the default font of Qt: "Segoe UI"
(This font ships with Qt, so we know it's safe to use)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm learning nodeeditor and looking to do something with it, this commit adds a font selection field