Skip to content

Commit

Permalink
using LF not CRLF
Browse files Browse the repository at this point in the history
  • Loading branch information
jinfeihan57 committed Jul 31, 2022
1 parent 21294d8 commit 6bfbed6
Showing 1 changed file with 1,447 additions and 1,447 deletions.
Loading

3 comments on commit 6bfbed6

@cielavenir
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinfeihan57 I understand your intention but you should follow the original source code so that you can upgrade the base 7-zip safely.

@cielavenir
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tansy
Copy link
Contributor

@tansy tansy commented on 6bfbed6 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's *nix project so it uses "*nix" line endings. Even Microsoft in their Windows-classic-samples and even VC2008Samples (and they are from 2008) uses LF line endings.
But more importantly, CRLF line endings screw all kinds of regex, look terrible in mcedit and cause all sorts of trouble you're not aware of or don't take into account.

Please sign in to comment.