You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
It's *nix project so it uses "*nix" line endings. Even Microsoft in their Windows-classic-samples and even VC2008Samples (and they are from 2008) uses LF line endings.
But more importantly, CRLF line endings screw all kinds of regex, look terrible in mcedit and cause all sorts of trouble you're not aware of or don't take into account.
6bfbed6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinfeihan57 I understand your intention but you should follow the original source code so that you can upgrade the base 7-zip safely.
6bfbed6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also did you forget https://github.com/jinfeihan57/p7zip/issues/179 ?
6bfbed6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's *nix project so it uses "*nix" line endings. Even Microsoft in their Windows-classic-samples and even VC2008Samples (and they are from 2008) uses LF line endings.
But more importantly, CRLF line endings screw all kinds of regex, look terrible in mcedit and cause all sorts of trouble you're not aware of or don't take into account.