fix args unpacking for corners mode (#442)

* fix args unpacking for corners mode * docs upgrade for rect corners mode * docs: deprecated setting
p5py · Oct 3, 2023 · 544ed95 · 544ed95
1 parent f786218
commit 544ed95
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/docs/guides/vscode.rst b/docs/guides/vscode.rst
@@ -15,11 +15,11 @@ Setup
 3. In the ``.vscode`` directory create a file called ``settings.json``
 4. In that file copy and paste all of these json settings:
 
-.. code:: 
+.. code::
 
     {
-        "python.linting.pylintArgs": [
-            "--disable", "E0102", 
+        "pylint.args": [
+            "--disable", "E0102",
             "--disable", "C0111",
             "--disable", "W0401",
             "--disable", "C0304",

diff --git a/p5/core/primitives.py b/p5/core/primitives.py
@@ -562,7 +562,7 @@ def rect(*args, mode: Optional[str] = None):
     :param args: For modes'CORNER' or 'CENTER' this has the form
         (width, height); for the 'RADIUS' this has the form
         (half_width, half_height); and for the 'CORNERS' mode, args
-        should be the corner opposite to `coordinate`.
+        should be two int values x, y - the coords of corner opposite to `coordinate`.
 
     :type: tuple
 
@@ -602,8 +602,7 @@ def rect(*args, mode: Optional[str] = None):
             height = 2 * half_height
         elif mode == "CORNERS":
             corner = Point(*coordinate)
-            (corner_2,) = args
-            corner_2 = Point(*corner_2)
+            corner_2 = Point(*args)
             width = corner_2.x - corner.x
             height = corner_2.y - corner.y
         else: