Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce service account keyless authentication #199

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

kharf
Copy link
Collaborator

@kharf kharf commented Apr 12, 2024

I also restructured the README as I think that a "getting started" via a usage section at the top attracts users more than a list of parameters.

Edit: should I change the style of the commit to non conventional?

@kharf kharf force-pushed the access-token branch 2 times, most recently from 6df5331 to c53f18e Compare April 12, 2024 06:18
@kharf kharf marked this pull request as ready for review April 12, 2024 06:22
@kharf kharf requested a review from a team as a code owner April 12, 2024 06:22
@kharf kharf changed the title feat: introduce service account keyless authentication Introduce service account keyless authentication Apr 12, 2024
Copy link
Member

@steinbrueckri steinbrueckri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@steinbrueckri steinbrueckri merged commit 6107e86 into master Apr 12, 2024
4 checks passed
@steinbrueckri steinbrueckri deleted the access-token branch April 12, 2024 07:04
Copy link
Member

@heubeck heubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thx Kevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants