Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyHMMER to get rid of binary dependency on HMMER #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prihoda
Copy link

@prihoda prihoda commented Jun 20, 2022

This is the first step towards enabling pip install anarci.. I'm not sure if any other changes to setup.py will be needed to get there, we would need to try that out.

  • Use pyhmmer instead of HMMER https://github.com/althonos/pyhmmer
    • Use pyhmmer instead of HMMER hmmbuild to build the HMM database
    • Use pyhmmer instead of HMMER hmmscan to find hits
  • Add unit tests
  • Run tests automatically each week, and also on each pull request using Github Actions

This way, ANARCI can be installed using:

pip install -r requirements.txt
python setup.py install

Speed is unaffected, I've observed just a slight increase in duration similar to the one reported here: https://github.com/althonos/pyhmmer#%EF%B8%8F-benchmarks

I'd be happy to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant