Remove all Cargo.toml files from spec.extensions
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef-Mak
force-pushed
the
patch-1
branch
3 times, most recently
from
f5c2256
to
ba7fee5
Compare
Youssef-Mak
commented
Jul 28, 2023
Youssef-Mak
commented
Jul 28, 2023
Youssef-Mak
commented
Aug 1, 2023
| @@ -45,6 +45,7 @@ def init(name = nil, gem_spec = nil) | |||
| gemspec.files.reject! { |f| f.end_with?(".rs") } | |||
| gemspec.files.reject! { |f| f.match?(/Cargo.(toml|lock)$/) } | |||
| gemspec.files.reject! { |f| extconf.end_with?(f) } | |||
| gemspec.extensions.reject! { |f| f.end_with?("Cargo.toml") } | |||
There was a problem hiding this comment.
Should we also consider Cargo.lock here?
There was a problem hiding this comment.
I think this is good, since rubygems will deny any Cargo.lock anyway.
Youssef-Mak
changed the title
Cargo.toml files from spec.extensions
|
🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
*/Cargo.(toml|lock)files should be removed fromspec.extensions.