Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session technology foundation site baseline #60

Conversation

Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Oct 7, 2024

No description provided.

@Aerilym Aerilym marked this pull request as ready for review October 7, 2024 01:08
@Aerilym Aerilym mentioned this pull request Oct 7, 2024
apps/foundation/public/favicon.svg Outdated Show resolved Hide resolved
apps/foundation/public/images/logo.svg Show resolved Hide resolved
turbo.json Show resolved Hide resolved
packages/util-logger/tests/index.spec.ts Show resolved Hide resolved
packages/ui/styles/global.css Show resolved Hide resolved
apps/foundation/app/(Site)/blog/page.tsx Show resolved Hide resolved
apps/foundation/app/(Site)/[slug]/page.tsx Show resolved Hide resolved
apps/foundation/.env.local.template Show resolved Hide resolved
Copy link
Collaborator Author

@Aerilym Aerilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made

apps/foundation/app/(Site)/not-found.tsx Outdated Show resolved Hide resolved
apps/foundation/components/DevSheet.tsx Show resolved Hide resolved
apps/foundation/components/DevSheet.tsx Show resolved Hide resolved
packages/ui/components/NavLink.tsx Show resolved Hide resolved
packages/ui/components/Typography.tsx Show resolved Hide resolved
packages/ui/styles/global.css Show resolved Hide resolved
packages/util-logger/tests/index.spec.ts Show resolved Hide resolved
turbo.json Show resolved Hide resolved
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple missed comments we need to resolve

packages/sanity-cms/components/SanityTiles.tsx Outdated Show resolved Hide resolved
packages/ui/components/Typography.tsx Show resolved Hide resolved
packages/sanity-cms/queries/getContent.ts Show resolved Hide resolved
packages/sanity-cms/queries/getAuthor.ts Show resolved Hide resolved
packages/sanity-cms/components/SanityTile.tsx Show resolved Hide resolved
apps/foundation/next.config.mjs Show resolved Hide resolved
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Aerilym Aerilym merged commit 582716f into sanity_cms_schemas_and_components Oct 10, 2024
6 of 7 checks passed
@Aerilym Aerilym deleted the session_technology_foundation_site_baseline branch October 10, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants